Extend systest with option to add split node setup #6506
+799
−375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
jellonek
force-pushed
the
nodesplit/systest
branch
from
ba20890
to
b69329f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## node-split-poc #6506 +/- ##
================================================
- Coverage 77.3% 77.3% -0.1%
================================================
Files 341 341
Lines 45737 45737
================================================
- Hits 35378 35367 -11
- Misses 8246 8254 +8
- Partials 2113 2116 +3 ☔ View full report in Codecov by Sentry. |
poszu
reviewed
Nov 28, 2024
jellonek
force-pushed
the
nodesplit/systest
branch
from
b69329f
to
6d7f68c
Compare
jellonek
changed the title
Note: split node setup will always deploy non smeshing node to which there will be deployed connected n-1 activation nodes. Because of that - node-split-size has to be set to 0 or >1.
jellonek
force-pushed
the
nodesplit/systest
branch
from
6d7f68c
to
f816a25
Compare
jellonek
force-pushed
the
nodesplit/systest
branch
from
7cefa78
to
6ef68e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tune systests to run smeshers as pair of pods - node and activation.
Description
Note: split node setup will always deploy non smeshing node
to which there will be deployed connected n-1 activation nodes.
Because of that - node-split-size has to be set to 0 or >1.
Test Plan
Manual testing.
TODO
OldSize != 0