Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - v2alpha1: support ineffectual transaction state #6468

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - v2alpha1: support ineffectual transaction state #6468

wants to merge 8 commits into from

Conversation

kacpersaw
Copy link
Contributor

Motivation

#6443 Introduced new transaction state TRANSACTION_STATE_INEFFECTUAL which was not supported by v2alpha1.

Closes #6466

@kacpersaw kacpersaw linked an issue Nov 19, 2024 that may be closed by this pull request
v2alpha1: Support INEFFECTUAL transaction state #6466
Closed
fasmat
fasmat reviewed Nov 19, 2024
View reviewed changes
api/grpcserver/v2alpha1/transaction_test.go Outdated Show resolved Hide resolved
api/grpcserver/v2alpha1/transaction.go Outdated Show resolved Hide resolved
api/grpcserver/v2alpha1/transaction.go Outdated
zap.String("tx_id", tx.ID.String()),
zap.Error(err),
)
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if returning nil is correct here. The transaction then has no state - instead I think it should be something like unknown/unspecified/error - maybe TransactionState_TRANSACTION_STATE_UNSPECIFIED?

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@kacpersaw
v2alpha1: support ineffectual transaction state (#6468)
9bd811b 
## Motivation

#6443 Introduced new transaction state `TRANSACTION_STATE_INEFFECTUAL` which was not supported by v2alpha1.

Closes #6466
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (9a221f7) to head (4600c43).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
api/grpcserver/v2alpha1/transaction.go 55.5% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6468     +/-   ##
=========================================
- Coverage     80.0%   79.9%   -0.1%     
=========================================
  Files          353     353             
  Lines        46424   46445     +21     
=========================================
+ Hits         37154   37155      +1     
- Misses        7170    7188     +18     
- Partials      2100    2102      +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@kacpersaw
v2alpha1: support ineffectual transaction state (#6468)
b1d421f 
## Motivation

#6443 Introduced new transaction state `TRANSACTION_STATE_INEFFECTUAL` which was not supported by v2alpha1.

Closes #6466
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@kacpersaw
v2alpha1: support ineffectual transaction state (#6468)
56d5d10 
## Motivation

#6443 Introduced new transaction state `TRANSACTION_STATE_INEFFECTUAL` which was not supported by v2alpha1.

Closes #6466
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@kacpersaw
v2alpha1: support ineffectual transaction state (#6468)
d203f45 
## Motivation

#6443 Introduced new transaction state `TRANSACTION_STATE_INEFFECTUAL` which was not supported by v2alpha1.

Closes #6466
@spacemesh-bors
Copy link

Build failed:

@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
@kacpersaw
v2alpha1: support ineffectual transaction state (#6468)
4d9554a 
## Motivation

#6443 Introduced new transaction state `TRANSACTION_STATE_INEFFECTUAL` which was not supported by v2alpha1.

Closes #6466
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title v2alpha1: support ineffectual transaction state [Merged by Bors] - v2alpha1: support ineffectual transaction state Nov 19, 2024
@spacemesh-bors spacemesh-bors bot closed this Nov 19, 2024
@spacemesh-bors spacemesh-bors bot deleted the 6466-v2alpha1-support-ineffectual-transaction-state branch November 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

@acud acud Awaiting requested review from acud acud is a code owner

@jellonek jellonek Awaiting requested review from jellonek jellonek is a code owner

Assignees
No one assigned
Labels
area/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2alpha1: Support INEFFECTUAL transaction state
2 participants
@kacpersaw @fasmat