Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add nodepool lifecycle for systemtests #6464

Closed
wants to merge 5 commits into from

Conversation

andres-spacemesh
Copy link
Contributor

Motivation

This PR automates the creation and cleanup of GKE node pools specifically for system tests in the CI pipeline. The goal is to provide dynamic, on-demand node pools that can be created before system tests and cleaned up afterward, improving resource utilization and reducing costs.

Description

  • Node Pool Creation: A new step has been added to the GitHub Actions pipeline to create a preemptible GKE node pool with a custom name based on the pipeline run ID.
  • Node pool labels are added to track the pipeline ID for easier identification.
  • Node Pool Deletion: A subsequent cleanup step has been added to delete the node pool after system tests are completed, ensuring that no unnecessary resources are left running.

This helps maintain stability in the infrastructure during system tests.

- Automate creation and deletion of a GKE node pool for systemtests
- Update nodeselector labels
@fasmat
Copy link
Member

fasmat commented Nov 18, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.9%. Comparing base (f4de865) to head (d35474a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6464   +/-   ##
=======================================
  Coverage     79.9%   79.9%           
=======================================
  Files          353     353           
  Lines        46424   46424           
=======================================
+ Hits         37122   37123    +1     
  Misses        7197    7197           
+ Partials      2105    2104    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dsmello
Copy link
Contributor

dsmello commented Nov 18, 2024

bors try

@spacemesh-bors
Copy link

try

Already running a review

@fasmat
Copy link
Member

fasmat commented Nov 18, 2024

bors cancel

@fasmat
Copy link
Member

fasmat commented Nov 18, 2024

bors try

@spacemesh-bors
Copy link

try

Already running a review

@andres-spacemesh
Copy link
Contributor Author

bors cancel

@andres-spacemesh
Copy link
Contributor Author

bors try

@spacemesh-bors
Copy link

try

Already running a review

@andres-spacemesh
Copy link
Contributor Author

bors cancel

@spacemesh-bors
Copy link

try

Timed out.

@andres-spacemesh
Copy link
Contributor Author

@fasmat
Copy link
Member

fasmat commented Nov 19, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 19, 2024
## Motivation

This PR automates the creation and cleanup of GKE node pools specifically for system tests in the CI pipeline. The goal is to provide dynamic, on-demand node pools that can be created before system tests and cleaned up afterward, improving resource utilization and reducing costs.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Add nodepool lifecycle for systemtests [Merged by Bors] - Add nodepool lifecycle for systemtests Nov 19, 2024
@spacemesh-bors spacemesh-bors bot closed this Nov 19, 2024
@spacemesh-bors spacemesh-bors bot deleted the systemtest-nodepool-creation-step branch November 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants