Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allow test runner to serve PoET proofs during distributed post test #6456

Closed
wants to merge 6 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Nov 14, 2024

Motivation

Sometimes the system test TestPostMalfeasanceProof fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.

Description

This happened some times before, the last time I saw it was here: https://github.com/spacemeshos/go-spacemesh/actions/runs/11832721136/job/32970020030

{"L":"WARN","T":"2024-11-14T08:19:07.534Z","N":"node.fetcher","M":"failed to get hash","requestId":"7c8517ac","hint":"POETDB","hash":"941eb277e5c7d566fa970d075fe7b375d122d7e315be52d755f89937bc78eb0e","error":"failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:19:07.535Z","N":"node.atxHandler","M":"failed to process atx gossip","requestId":"7c8517ac","sender":"12D3KooWRWM824Tfqc6jwV36SruBs12H7pNiqMtFR4unqEm56gCC","error":"fetching references for atx c2ab475e5e: fetching poet proof (941eb277e5): failed to negotiate protocol: protocols not supported: [hs/1]"} |  
{"L":"WARN","T":"2024-11-14T08:19:08.534Z","N":"node.fetcher","M":"failed to get hash","requestId":"5dc71984","hint":"POETDB","hash":"941eb277e5c7d566fa970d075fe7b375d122d7e315be52d755f89937bc78eb0e","error":"failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:19:08.534Z","N":"node.atxHandler","M":"failed to process atx gossip","requestId":"5dc71984","sender":"12D3KooWRWM824Tfqc6jwV36SruBs12H7pNiqMtFR4unqEm56gCC","error":"fetching references for atx b3d677dffe: fetching poet proof (941eb277e5): failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:20:07.585Z","N":"node.fetcher","M":"failed to get hash","requestId":"13642a8f","hint":"POETDB","hash":"172dfbc551b6fbfe142ce9e135df06ea1f45598dd4c821e3f1440c44704a2a8d","error":"failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:20:07.585Z","N":"node.fetcher","M":"failed to get hash","requestId":"9a8f7d08","hint":"POETDB","hash":"172dfbc551b6fbfe142ce9e135df06ea1f45598dd4c821e3f1440c44704a2a8d","error":"failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:20:07.585Z","N":"node.atxHandler","M":"failed to process atx gossip","requestId":"13642a8f","sender":"12D3KooWRWM824Tfqc6jwV36SruBs12H7pNiqMtFR4unqEm56gCC","error":"fetching references for atx 3fec9b7835: fetching poet proof (172dfbc551): failed to negotiate protocol: protocols not supported: [hs/1]"}
{"L":"WARN","T":"2024-11-14T08:20:07.585Z","N":"node.atxHandler","M":"failed to process atx gossip","requestId":"9a8f7d08","sender":"12D3KooWRWM824Tfqc6jwV36SruBs12H7pNiqMtFR4unqEm56gCC","error":"fetching references for atx 31f11fada8: fetching poet proof (172dfbc551): failed to negotiate protocol: protocols not supported: [hs/1]"}

This should solve this issue.

Test Plan

Test now passes without complaining about missing dependency.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Nov 14, 2024
@fasmat
Copy link
Member Author

fasmat commented Nov 14, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (8e1c3c9) to head (849c8d0).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
malfeasance/wire/malfeasance.go 0.0% 4 Missing ⚠️
node/node.go 87.5% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6456     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.1%     
=========================================
  Files          352     352             
  Lines        46075   46079      +4     
=========================================
- Hits         36857   36838     -19     
- Misses        7133    7159     +26     
+ Partials      2085    2082      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Nov 14, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 14, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Nov 14, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 14, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Nov 14, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Nov 15, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 15, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed:

  • ci-status

@fasmat
Copy link
Member Author

fasmat commented Nov 15, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 15, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Nov 15, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Build failed:

  • systest-status

@fasmat
Copy link
Member Author

fasmat commented Nov 15, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Nov 15, 2024
…6456)

## Motivation

Sometimes the system test `TestPostMalfeasanceProof` fails because dependencies for the created ATX cannot be fetched by the receiver of it's gossip. This adds a fetcher that allows another peer to request that data if necessary.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Allow test runner to serve PoET proofs during distributed post test [Merged by Bors] - Allow test runner to serve PoET proofs during distributed post test Nov 15, 2024
@spacemesh-bors spacemesh-bors bot closed this Nov 15, 2024
@spacemesh-bors spacemesh-bors bot deleted the deflake-distributed-post-malfeasance branch November 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants