-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added better error handling when article has been cleared from cache #447
Conversation
For feed if for some reason cache was cleared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the problem here is that you are removing the feedback to the user that something went wrong.
The current situation is certainly not the best, but this will lead to confusing bug reports where sometimes the snippet is shown instead of the real text.
Instead, could you perhaps update where the articles are saved?
|
This is just a quick hot fix, and changing the location wouldn't help for already deleted saved article. Not to mention migrating exisiting articles from the cachedir to another location is a bit out of my league, where the maintainer of this project with more knowledge would be more suited to do. I do not want to the cause for even more article to get deleted because I mess up the migration. |
IMO, |
@asl97 just run |
For feed if for some reason cache was cleared.
Ideally, at least the non full article shouldn't be written into the cachedir as it is a key part of the whole "Offline reading" mentioned in Features.
https://developer.android.com/training/data-storage/app-specific#internal-remove-cache
I did accidentally put a huge git repo recently into a syncthing folder which I deleted afterwards but that might had cause the article to get deleted due to running very low on storage space
This hotfix is not ideal but at least it's something, as I doubt it would be possible to retrieve the lost data. screenshot:
I would appreciate if you could fix the tag on #443 too
Having an situation where the feed get lost ('Found nothing to fetch') is a bug.