-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added article summary with OpenAI integration #399
Conversation
@spacecowboy please take a look |
Sure. Let me know when you think the functionality is done. The structure seems reasonable. I noted some hard-coded english strings and some lack of padding in layouts, but I'll hold off on reviewing in detail until later. What issues are you having with "theming of buttons and progress bars"? |
751bef2
to
163fb61
Compare
|
Theme isn't applying because you are importing the wrong assets.
Only import Exception to that is things from the |
163fb61
to
9f26a30
Compare
Thanks forgot about material 1 |
Converted the PR to a draft. Please let me know when it's ready for review |
What's missing? I don't plan to add anything |
Well CI is failing for one.
|
9f26a30
to
b1a7410
Compare
@spacecowboy Since I can't run CI, please run and let me know if it passes |
Flipped a switch so it should run automatically from now on |
Also, please stop force-pushing. It makes it hard to understand what changes. I will squash merge your PR when/if it's merged anyway |
I use rebase, I prefer my changes to be a single commit on top any other change and not spread across timeline, you can see and review all the changes in "Files changes" tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be a cool feature to the app. Thanks for working on it!
I have noted some issues inline, and there is a problem with the settings layout on tablets:
But the biggest thing is the settings UX. It has a save/cancel button in a UI where everything else saves directly on edits.
As I see it, it should either:
- be changed so it's only the Editable section that's used. And save the fields directly as they are edited. But that may be non-ideal.
- or change so that the
OpenAI Integration
section only has one settings, a text button which opens a new screen/dialog, in which asave
andcancel
buttons can be present. Kind of how theEdit feed
screen works. TheBlock list
setting works like this and opens a popup. WhileDevice sync
opens an entire screen.
What to you think?
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/OpenAISection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/OpenAISection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/OpenAISection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/OpenAISection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/OpenAISection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/settings/VisualTransformationApiKey.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nononsenseapps/feeder/ui/compose/feedarticle/ArticleScreen.kt
Show resolved
Hide resolved
Will change to dialog, I just don't like dialogs as a UX pattern and with Compose it much easier to have inline experience, but I agree that it might be better for familiarity Also I have more ideas for integration:
|
Co-authored-by: Jonas Kalderstam <[email protected]>
Sorry for the delay in review. I think this looks good now. Thanks for your hard work 👍 |
Add summarize feature which fetching an article content and summarizes it using OpenAI API.
Api key needs to be provided in the settings