Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feed title empty on initial app start #388

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

svenjacobs
Copy link
Contributor

On the first app start the feed title is empty.

Screenshot_20241013_124246

SettingsStore returns ID_UNSET for the current feed because the user has not explicitly selected a feed yet.

The PR fixes it by setting FeedType to ALL_FEEDS when ID is ID_UNSET (and tag is blank).

@spacecowboy
Copy link
Owner

thank you @svenjacobs !

@spacecowboy spacecowboy enabled auto-merge (rebase) October 13, 2024 13:09
@spacecowboy spacecowboy merged commit bed721c into spacecowboy:master Oct 13, 2024
2 checks passed
@svenjacobs svenjacobs deleted the fix/feed-title-empty branch October 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants