Fixed parsed width/height of iframes

spacecowboy · Jun 4, 2024 · 8ac5fa6 · 8ac5fa6
1 parent 4a96932
commit 8ac5fa6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/src/main/java/com/nononsenseapps/feeder/model/html/HtmlLinearizer.kt b/app/src/main/java/com/nononsenseapps/feeder/model/html/HtmlLinearizer.kt
@@ -630,6 +630,8 @@ class HtmlLinearizer {
     }
 
     private fun ListBuilderScope<LinearElement>.parseIframeVideo(element: Element) {
+        val width = element.attr("width").toIntOrNull()
+        val height = element.attr("height").toIntOrNull()
         getVideo(element.attr("abs:src").ifBlank { null })?.let { video ->
             add(
                 LinearVideo(
@@ -639,8 +641,8 @@ class HtmlLinearizer {
                                 uri = video.src,
                                 link = video.link,
                                 imageThumbnail = video.imageUrl,
-                                widthPx = video.width,
-                                heightPx = video.height,
+                                widthPx = width ?: video.width,
+                                heightPx = height ?: video.height,
                                 mimeType = null,
                             ),
                         ),

diff --git a/app/src/test/java/com/nononsenseapps/feeder/model/html/HtmlLinearizerTest.kt b/app/src/test/java/com/nononsenseapps/feeder/model/html/HtmlLinearizerTest.kt
@@ -622,8 +622,8 @@ class HtmlLinearizerTest {
                             "https://www.youtube.com/embed/x_m02bUxfvE?feature=oembed",
                             "https://www.youtube.com/watch?v=x_m02bUxfvE",
                             "http://img.youtube.com/vi/x_m02bUxfvE/hqdefault.jpg",
-                            480,
-                            360,
+                            1170,
+                            658,
                             null,
                         ),
                     ),
-Original file line number
+Diff line change
@@ Expand Up / @@ -622,8 +622,8 @@ class HtmlLinearizerTest { @@
                                 "https://www.youtube.com/embed/x_m02bUxfvE?feature=oembed",
                                 "https://www.youtube.com/watch?v=x_m02bUxfvE",
                                 "http://img.youtube.com/vi/x_m02bUxfvE/hqdefault.jpg",
-,
-,
+,
+,
                                 null,
                             ),
                         ),
@@ Expand Down @@