Skip to content

Commit

Permalink
added feed item styles for tablets (no longer hidden on tablet)
Browse files Browse the repository at this point in the history
Signed-off-by: Jonas Kalderstam <[email protected]>
  • Loading branch information
spacecowboy committed Dec 3, 2024
1 parent 52bc4e0 commit 58c7a8b
Showing 1 changed file with 8 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ import com.nononsenseapps.feeder.ui.compose.theme.SetStatusBarColorToMatchScroll
import com.nononsenseapps.feeder.ui.compose.utils.ImmutableHolder
import com.nononsenseapps.feeder.ui.compose.utils.WithAllPreviewProviders
import com.nononsenseapps.feeder.ui.compose.utils.immutableListHolderOf
import com.nononsenseapps.feeder.ui.compose.utils.isCompactDevice
import com.nononsenseapps.feeder.ui.compose.utils.onKeyEventLikeEscape
import com.nononsenseapps.feeder.ui.compose.utils.rememberApiPermissionState
import com.nononsenseapps.feeder.util.ActivityLauncher
Expand Down Expand Up @@ -556,16 +555,14 @@ fun SettingsList(
onCheckedChange = onOpenDrawerOnFab,
)

if (isCompactDevice()) {
MenuSetting(
title = stringResource(id = R.string.feed_item_style),
currentValue = feedItemStyleValue.asFeedItemStyleOption(),
values = ImmutableHolder(FeedItemStyle.values().map { it.asFeedItemStyleOption() }),
onSelection = {
onFeedItemStyleChange(it.feedItemStyle)
},
)
}
MenuSetting(
title = stringResource(id = R.string.feed_item_style),
currentValue = feedItemStyleValue.asFeedItemStyleOption(),
values = ImmutableHolder(FeedItemStyle.values().map { it.asFeedItemStyleOption() }),
onSelection = {
onFeedItemStyleChange(it.feedItemStyle)
},
)

MenuSetting(
title = stringResource(id = R.string.max_lines),
Expand Down

0 comments on commit 58c7a8b

Please sign in to comment.