feat: range check arbitrary size columns #473
Open
+255
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin-Ray
commented
Jan 13, 2025
| @@ -5,6 +5,7 @@ use bitwise_verification::{verify_constant_abs_decomposition, verify_constant_si | |||
| mod bitwise_verification_test; | |||
| mod sign_expr; | |||
| pub(crate) use sign_expr::{prover_evaluate_sign, result_evaluate_sign, verifier_evaluate_sign}; | |||
| #[allow(clippy::needless_range_loop)] // keep the loop for readability for now, refactor later | |||
There was a problem hiding this comment.
I will change this back immediately in the next PR, this was super important to keep for now so that we can understand the loops in the range check functions
Dustin-Ray
commented
Jan 13, 2025
| @@ -137,8 +146,28 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn we_can_prove_a_range_check_with_range_0_to_256() { | |||
| let data = owned_table([scalar("a", 0..256)]); | |||
| #[allow(clippy::cast_sign_loss)] | |||
There was a problem hiding this comment.
this is added because the range used to index the scalars while creating the owned table can be negative but here it doesnt matter because its testing positive ranges only and we cant create a Scalar from but Uints
Dustin-Ray
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, it is possible to argue the correct ranges of scalars up to the word value size, but anything below or beyond this value (currently 256 for byte sized words) will fail to verify. This PR expands range check on a scalar column to arbitrary lengths.
What changes are included in this PR?
Are these changes tested?