refactor: replace Commitment::append_to_transcript with to_transcript_bytes
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
force-pushed
the
refactor/to-transcript-bytes
branch
from
9324f0e to
653ab13
Compare
JayWhite2357
force-pushed
the
refactor/to-transcript-bytes
branch
from
653ab13 to
f249d61
Compare
JayWhite2357
force-pushed
the
refactor/to-transcript-bytes
branch
from
f249d61 to
7593fc5
Compare
stuarttimwhite
approved these changes
Jan 14, 2025
|
🎉 This PR is included in version 0.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We will want to serialize commitments in a manner compatible with the transcript. This facilitates doing this without duplicating code.
What changes are included in this PR?
Commitment::append_to_transcriptis removed andto_transcript_bytesis added instead. Usage is replaced as well.Are these changes tested?
Yes.