refactor!: identifier to ident and update docs #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
reviewed
Dec 17, 2024
iajoiner
reviewed
Dec 17, 2024
iajoiner
reviewed
Dec 17, 2024
iajoiner
reviewed
Dec 17, 2024
iajoiner
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Really thanks for your PR!
General comments:
- You don't need to remove the word "identifier" when it refers to the general concept of identifiers rather than
proof_of_sql_parser::Identifier - .The comments on the two table util files need to be fixed in the entire files rather than in just the two instances I mentioned.
varshith257
commented
Dec 17, 2024
varshith257
changed the title
varshith257
force-pushed
the
update-docs
branch
from
5a641a5 to
b4587bf
Compare
iajoiner
force-pushed
the
update-docs
branch
from
b4587bf to
64ec9d0
Compare
varshith257
force-pushed
the
update-docs
branch
2 times, most recently
from
9340da5 to
ef5c2f1
Compare
iajoiner
approved these changes
Dec 17, 2024
iajoiner
requested changes
Dec 17, 2024
|
The doc test is failing if we do the same and getting clippy issue there |
|
@varshith257 Which issues? |
varshith257
force-pushed
the
update-docs
branch
2 times, most recently
from
db11bb7 to
2c1812f
Compare
varshith257
force-pushed
the
update-docs
branch
from
2c1812f to
cff9523
Compare
iajoiner
approved these changes
Dec 18, 2024
JayWhite2357
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version 0.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
To update docs to reflect the migration of Identifier -> Ident
What changes are included in this PR?
Are these changes tested?
Part of #235