feat: allow FirstRoundBuilder to produce MLEs
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/first-round-commitment
branch
6 times, most recently
from
ce14b9b to
edc345d
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
8 times, most recently
from
8efca6f to
acd7af8
Compare
Dustin-Ray
reviewed
Dec 13, 2024
iajoiner
force-pushed
the
feat/first-round-commitment
branch
6 times, most recently
from
4fff0d7 to
a716d7c
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
5 times, most recently
from
bb6a305 to
6b4be2f
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
from
6b4be2f to
6ee2f72
Compare
Dustin-Ray
force-pushed
the
feat/first-round-commitment
branch
from
6ee2f72 to
3e0feff
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
from
3e0feff to
a3bed37
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
3 times, most recently
from
8d1e25d to
c2d9b0d
Compare
iajoiner
force-pushed
the
feat/first-round-commitment
branch
from
c2d9b0d to
a922e1b
Compare
JayWhite2357
approved these changes
Dec 20, 2024
|
🎉 This PR is included in version 0.64.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
For range check and joins we need to have pre-challenge committing of columns. As a result we need to add such functionalities to
FirstRoundBuilder.What changes are included in this PR?
FirstRoundBuilderto produce MLEs.Are these changes tested?
Will be.