Skip to content

Commit

Permalink
feat!: remove old postprocessing and polars entirely (#84)
Browse files Browse the repository at this point in the history
# Rationale for this change
This PR is the last one in polars removal which is the removal itself.
It should only be merged once everything else in the process get merged.
<!--
Why are you proposing this change? If this is already explained clearly
in the linked Jira ticket then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

# What changes are included in this PR?
- remove `sql::transform`
- remove Arrow <-> Polars conversion
- remove dependencies `polars`, `dyn_partial_eq` and `typetag`
<!--
There is no need to duplicate the description in the ticket here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

# Are these changes tested?
N/A
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
  • Loading branch information
iajoiner authored Aug 16, 2024
1 parent 0f008d7 commit 54fbc9a
Show file tree
Hide file tree
Showing 24 changed files with 2 additions and 2,609 deletions.
5 changes: 1 addition & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ bigdecimal = { version = "0.4.5", features = ["serde"] }
blake3 = { version = "1.3.3" }
blitzar = { version = "3.0.2" }
bumpalo = { version = "3.11.0" }
bytemuck = {version = "1.14.2" }
bytemuck = {version = "1.16.3", features = ["derive"]}
byte-slice-cast = { version = "1.2.1" }
clap = { version = "4.5.4" }
criterion = { version = "0.5.1" }
chrono = { version = "0.4.38" }
curve25519-dalek = { version = "4", features = ["rand_core"] }
derive_more = { version = "0.99" }
dyn_partial_eq = { version = "0.1.2" }
flexbuffers = { version = "2.0.0" }
indexmap = { version = "2.1" }
itertools = { version = "0.13.0" }
Expand All @@ -43,7 +42,6 @@ num-traits = { version = "0.2" }
num-bigint = { version = "0.4.4", default-features = false }
opentelemetry = { version = "0.23.0" }
opentelemetry-jaeger = { version = "0.20.0" }
polars = { version = "0.33.1", default-features = false, features = ["dtype-i16"] }
postcard = { version = "1.0" }
proof-of-sql = { path = "crates/proof-of-sql" } # We automatically update this line during release. So do not modify it!
proof-of-sql-parser = { path = "crates/proof-of-sql-parser" } # We automatically update this line during release. So do not modify it!
Expand All @@ -56,7 +54,6 @@ thiserror = { version = "1" }
tracing = { version = "0.1.36" }
tracing-opentelemetry = { version = "0.22.0" }
tracing-subscriber = { version = "0.3.0" }
typetag = { version = "0.2.13" }
wasm-bindgen = { version = "0.2.92" }
zerocopy = { version = "0.7.34" }

Expand Down
6 changes: 1 addition & 5 deletions crates/proof-of-sql/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,12 @@ byte-slice-cast = { workspace = true }
curve25519-dalek = { workspace = true, features = ["serde"] }
chrono = {workspace = true, features = ["serde"]}
derive_more = { workspace = true }
dyn_partial_eq = { workspace = true }
indexmap = { workspace = true }
indexmap = { workspace = true, features = ["serde"] }
itertools = { workspace = true }
lazy_static = { workspace = true }
merlin = { workspace = true }
num-traits = { workspace = true }
num-bigint = { workspace = true, default-features = false }
polars = { workspace = true, features = ["lazy", "bigidx", "dtype-decimal", "serde-lazy"] }
postcard = { workspace = true, features = ["alloc"] }
proof-of-sql-parser = { workspace = true }
rand = { workspace = true, optional = true }
Expand All @@ -48,7 +46,6 @@ serde = { workspace = true, features = ["serde_derive"] }
serde_json = { workspace = true }
thiserror = { workspace = true }
tracing = { workspace = true, features = ["attributes"] }
typetag = { workspace = true }
zerocopy = { workspace = true }

[dev_dependencies]
Expand All @@ -58,7 +55,6 @@ clap = { workspace = true, features = ["derive"] }
criterion = { workspace = true, features = ["html_reports"] }
opentelemetry = { workspace = true }
opentelemetry-jaeger = { workspace = true }
polars = { workspace = true, features = ["lazy"] }
rand = { workspace = true }
rand_core = { workspace = true }
serde_json = { workspace = true }
Expand Down
5 changes: 0 additions & 5 deletions crates/proof-of-sql/src/base/database/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ pub use table_ref::TableRef;
mod arrow_array_to_column_conversion;
pub use arrow_array_to_column_conversion::{ArrayRefExt, ArrowArrayToColumnConversionError};

mod record_batch_dataframe_conversion;
pub(crate) use record_batch_dataframe_conversion::{
dataframe_to_record_batch, record_batch_to_dataframe,
};

mod record_batch_utility;
pub use record_batch_utility::ToArrow;

Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion crates/proof-of-sql/src/sql/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ pub mod ast;
pub mod parse;
pub mod postprocessing;
pub mod proof;
pub mod transform;
Loading

0 comments on commit 54fbc9a

Please sign in to comment.