Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating quran #32901

Closed
wants to merge 6 commits into from
Closed

Creating quran #32901

wants to merge 6 commits into from

Conversation

voko421
Copy link

@voko421 voko421 commented Oct 19, 2024

About the PR

Add quran in game

Why / Balance

I saw quran in textures and wanna to add it in game

Requirements

I haven't finished making the quran and I need help, I'm a beginner prototyper. Now the quran has not been completely added to the game, it still needs to be added to the priest's closet/inventory, I really need help and I just want to show what I could do. it's maybe mistake in code, i checked only prototype and sprites

Breaking changes

Adding quran in the game(not finished)

🆑

  • add: Added quran

Add objective for thief
Add locale in chapel
Add objective for steal Quran
fixed the mistake
Add quran in objectiveGroups
@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Oct 19, 2024
@voko421
Copy link
Author

voko421 commented Oct 19, 2024

Maybe it didn't need to quran.ftl

@lzk228
Copy link
Contributor

lzk228 commented Oct 19, 2024

#27400
please read this pr

@Uhboer
Copy link

Uhboer commented Oct 19, 2024

билдецкий не для тебя, спрайты не добавил, овощь

@voko421
Copy link
Author

voko421 commented Oct 19, 2024

#27400 please read this pr

I know that they added a Koran sprite, the path to the RSI of this sprite is indicated in the prototype

@slarticodefast
Copy link
Member

#27400 please read this pr

I know that they added a Koran sprite, the path to the RSI of this sprite is indicated in the prototype

They meant the design doc linked in the PR. The idea in there was not to make it a separate item, but to make the book item customizable using a menu and giving it a slightly different effect when used.

@superjj18
Copy link

We could do the tg thing where the Bible has a radial menu to select which sprite you want

@voko421 voko421 closed this Oct 19, 2024
@voko421 voko421 reopened this Oct 19, 2024
@voko421
Copy link
Author

voko421 commented Oct 19, 2024

they really need mechanics

@voko421 voko421 closed this Oct 19, 2024
@Terraspark4941
Copy link
Contributor

We could do the tg thing where the Bible has a radial menu to select which sprite you want

basically exactly what I wanted to achieve (i made the sprite and design doc)
however the mechanics have not been implemented as I wanted; in short:

...Quran, will be implemented with a different AoE healing mechanic to boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants