Update Tmax to computationally sound limit #24370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
Partmedia
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Given that the purpose of the limit is to constrain epsilon, this seems reasonable. However this hardly matters, since if someone managed to get something to this temperature, something is probably wrong.
|
Aww, not even a little magnetic confinement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Makes the Atmospherics.Tmax slightly higher, from 200kK to 262kK due to how floats work.
Why / Balance
Might as well go the full forte with defining the domain of calculation. This is the largest number that an epsilon of 1/64 = 0.015625K can exist, and any larger epsilon will probably be unacceptable at SS14's tickrates. In hindsight, I think this should be made a
CCVar, however, I'm not currently capable of doing that due to physical GPU-ending reasons (fuck you nvidia)Technical details
https://float.exposed/0x48800000 (fiddle with
Raw Hexadecimal Integer Value)Breaking changes
None.
Changelog
no cl no fun (it's literally a constant change)