-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atmos time compression #21954
Merged
Partmedia
merged 4 commits into
space-wizards:master
from
Partmedia:notafet/atmos_speedup
Dec 11, 2023
Merged
Add atmos time compression #21954
Partmedia
merged 4 commits into
space-wizards:master
from
Partmedia:notafet/atmos_speedup
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add atmos.speedup which is effectively a atmos-only time compression CVar. This adjusts heat capacities and transfer rates to effectively globally speed up the time constants of atmos. This allows faster response to heating/cooling changes and faster cleanups (by buffing scrubbers, pumps, and everything else) that is tunable through one global time compression CVar. It also achieves this without any thermodynamic unsoundness.
)" This reverts commit 3327fdd.
People want all the benefits of time compression without the downsides.
ElectroJr
previously requested changes
Nov 28, 2023
ElectroJr
reviewed
Nov 28, 2023
air alarms do this automatically |
Partmedia
added
the
S: DO NOT MERGE
Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft.
label
Dec 11, 2023
Adding do not merge for now since this also makes producing frezon way too fast. |
just make spacing fast again |
Partmedia
removed
the
S: DO NOT MERGE
Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft.
label
Dec 11, 2023
Since frezon prices were just set to zero, and since there are a few frezon adjustments in the pipeline, I plan to merge this soon. If there is too much fallout the |
BasedUser
pushed a commit
to BasedUser/space-station-14
that referenced
this pull request
Dec 16, 2023
Add atmos.speedup which is effectively a atmos-only time compression CVar. This adjusts heat capacities and transfer rates to effectively globally speed up the time constants of atmos. This allows faster response to heating/cooling changes and faster cleanups (by buffing scrubbers, pumps, and everything else) that is tunable through one global time compression CVar. It also achieves this without any thermodynamic unsoundness.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Add
atmos.speedup
which is effectively a atmos-only time compression CVar. This adjusts heat capacities and transfer rates to effectively globally speed up the time constants of atmos.This allows faster response to heating/cooling changes and faster cleanups (by buffing scrubbers, pumps, and everything else) that is tunable through one global time compression CVar. It also achieves this without any thermodynamic unsoundness.
And if anyone complains, this number can be increased/decreased as needed without fear of breaking anything.
Why / Balance
Multiple people complained that atmos is too slow/not useful/not fun.
Atmos variables were balanced based on real specific heat capacities and semi-realistic transfer rates. However, things typically happen too slowly in real life for people to feel like they're having fun in a game. See: space-wizards/docs#78
It is also not okay to globally buff all numbers, because:
Technical details
Adds a
atmos.speedup
CVar. It is used in two ways:sqrt(atmos.speedup)
(via the newAtmosphereSystem.PumpSpeedup()
function)Teach all the atmos devices that used MaxTransferRate (or derived variables) to multiply by the new
PumpSpeedup()
.Media
Atmos techs who respond to a gas leak by turning on widenet can now fix problems in a reasonable amount of time. Note that things are still kind of slow if you don't send an atmos tech to go deal with the problem.
out-2023-11-28_11.16.56.mp4
Breaking changes
None
Changelog
🆑 notafet