Log errors when encountering entity data fields #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
added
Area: Serialization
Status: Requires Content PR
|
Resolves space-wizards/space-station-14#34030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISerializationManagerwill now log errors if it encountersEntity<T>data-fields, which have never been supported but have been getting used in some content code. Currently this is just done with a blacklisting attribute, because I don't think there's any easy way to automate it with the current serialization system.This PR also makes some yaml node validation methods more robust, so that they return error nodes instead of throwing exceptions.
Fixes #4855
Requires space-wizards/space-station-14#34083