Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds osx-arm64 support. Still in testing stages and this is still very early. Draft for feedback.
In local tests this seems to all work, and I played a full game on Lizard and it worked almost perfectly the entire time and was pegged at 120 FPS...
but some part of the map had a client-side entity that caused my screen to stop updating entirely. Though the game was still responsive, so I could walk away from the bugged area and everything would resume, it is pretty brutal. Traceback is below under Known Issues. I don't know more than that yet.
Still, things seem promising.
The number one open question of course is: is this a good idea at all, and now that I have it somewhat working, I can see arguments for both sides.
Changes
2
in it to be compatible with the dylib that is packed in the build deps, and to stop problems like MIDI broken again #3376mac-apple-silicon
Upstream requirements
Known issues
This has been happening a long time and also happens under Rosetta - e.g. Unable to open MIDI file on macOS space-station-14#5186 - and the GLFW maintainers traced it back to bugs introduced by Apple. Doesn't seem like there is much we can do here. Some minor revisions of OSX remove the bug, but other ones seem to bring it back.
Questions
$(ProcessArchitecture)
is doing what I want? It seems to work locally. Could just remove the conditional, it's not hurting anybody