Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ubuntu 22.04 #685

Merged
merged 8 commits into from
Aug 23, 2023
Merged

feat: add support for ubuntu 22.04 #685

merged 8 commits into from
Aug 23, 2023

Conversation

leoalves100
Copy link
Contributor

Description

  • Add support for Ubuntu 22.04

Issues Resolved

List any existing issues this PR resolves

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@leoalves100 leoalves100 requested a review from a team as a code owner December 20, 2022 02:18
@ramereth
Copy link
Contributor

@leoalves100 can you please resolve the rspec and cookstyle failures?

@leoalves100
Copy link
Contributor Author

@ramereth adjustment done

@damacus
Copy link
Member

damacus commented Dec 20, 2022

Looks like there's some fun with the matrix to fix yet

https://github.com/sous-chefs/mysql/actions/runs/3740217446/jobs/6348344596

@ramereth ramereth force-pushed the feat/add-support-ubuntu-22-04 branch from c049270 to 738787a Compare December 21, 2022 00:05
@ramereth ramereth added the Release: Minor Release to Chef Supermarket as a minor release when merged label Dec 21, 2022
@RenatoMorenoR
Copy link

Hi friends, how can we help with this PR 😄. We have several system with this cookbook and we started migration to ubuntu 22.04 and we encountered the problem that it is not compatible. I am available to be able to help in whatever way we can to push this development. Thanks 😄

@damacus damacus added the Waiting on Contributor Awaiting on the person who raised this to update label Mar 20, 2023
@damacus
Copy link
Member

damacus commented Apr 4, 2023

@RenatoMorenoR thanks for the help. We do need the test passing before we can merge this in.

I've updated some of the testing in #697. So this will also need rebasing.

@leoalves100 leoalves100 force-pushed the feat/add-support-ubuntu-22-04 branch from 738787a to f409acc Compare April 11, 2023 03:34
@leoalves100 leoalves100 force-pushed the feat/add-support-ubuntu-22-04 branch from f409acc to 495e434 Compare April 11, 2023 03:36
@leoalves100
Copy link
Contributor Author

@damacus Thank you for solving the tests. I can't identify why check-metadata is failing, can you help me please?

@DeWaRs1206
Copy link

@leoalves100 @damacus any chance to have this PR reviewed ?

ramereth
ramereth requested changes Jul 31, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@ramereth
Fix Changelog
057a726 
Signed-off-by: Lance Albertson <[email protected]>
@ramereth ramereth merged commit 8c1678a into sous-chefs:main Aug 23, 2023
15 of 30 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 11.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramereth ramereth ramereth requested changes

Assignees
No one assigned
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged Waiting on Contributor Awaiting on the person who raised this to update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@leoalves100 @ramereth @damacus @RenatoMorenoR @DeWaRs1206 @kitchen-porter @xorima