Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix possible bug in mpich 4+ that needs communicators to be cleared from messages before free.
Rationale for changes
Using mpich 4.1.2 several tests failed in the finalization phase where mpich reported, that messages were dangling on a communicator to free. This patch just reads all messages before freeing the communicator, which fixes the issue.
A second issue was that the openmpi flag was not propagated into the top-level CMakeLists.txt using set(... PARENT_SCOPE) which lead to test errors, because the generated hostsfile was not referenced and also other openmpi specific flags were not set. The flag is now a global property, that is introduced in the top-level CMakeLists.txt and this fixes the issue.
Tested with mpich 4.1.2, openmpi 4.1.5 and intel mpi 2021.13
Fix for issue #781, #783, #769, #761
Additional info and certifications
This pull request (PR) is a:
I certify that
OpenCoarrays developer a chance to review my proposed code
be introduced)
Code coverage data