Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONOTMERGE: Purge communicator before free on mpich4+ #787

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Oct 2, 2024

coverage on master
Codecov branch

Summary of changes

Purge all pending messages from the communicator before freeing it.

Rationale for changes

MPICH 4+ had strange errors when freeing a communicator that had dangling messages. This patch removes all messages before freeing the communicator.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

@vehre vehre changed the base branch from main to vehre/issue-783-fix-copy-self October 2, 2024 13:39
Mpich from 4.0 on seems to bug when there is a message dangling on
freeing the communicator.
@vehre vehre force-pushed the vehre/issue-781-clear-communicator-4-mpich branch from 72a6216 to 4d97203 Compare October 2, 2024 13:54
@vehre
Copy link
Collaborator Author

vehre commented Oct 2, 2024

The initial version of the patch had no guard for MPICH. The fix is only needed an valid for MPICH. So that has been added.

@vehre vehre changed the title Purge communicator before free on mpich4+ DONOTMERGE: Purge communicator before free on mpich4+ Oct 2, 2024
@vehre
Copy link
Collaborator Author

vehre commented Oct 2, 2024

I have to rethink this. Does not work as expected. Closing.

@vehre vehre closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant