Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO after making changes in website - app.js #178

Closed
wants to merge 39 commits into from
Closed

TODO after making changes in website - app.js #178

wants to merge 39 commits into from

Conversation

suprith-hub
Copy link
Contributor

But I wasn't able to test website in local. I hope CI takes care of it, if can I view for errors in the deployments if any in the website It would have been better

@suprith-hub suprith-hub changed the title Hi I have made changes in app.js of the website too TODO after making changes in website Mar 12, 2024
@suprith-hub suprith-hub changed the title TODO after making changes in website TODO after making changes in website - app.js Mar 12, 2024
@jviotti
Copy link
Member

jviotti commented Mar 13, 2024

Let me take a look later today. I'll try to run it locally. I'm still baffled about why GitHub Actions are not triggering for you :(

@suprith-hub
Copy link
Contributor Author

Let me take a look later today. I'll try to run it locally. I'm still baffled about why GitHub Actions are not triggering for you :(

okay great.. 👍

@jviotti
Copy link
Member

jviotti commented Mar 13, 2024

Can you sync your PR branch with the latest stuff from master? I believe CI will run now for you

@suprith-hub
Copy link
Contributor Author

Can you sync your PR branch with the latest stuff from master? I believe CI will run now for you

I am getting some merge conflicts, I will resolve that and CI tests are working good..

@jviotti
Copy link
Member

jviotti commented Mar 14, 2024

Looks like its all green, but you need to perform the DCO with Signed-Off-By

dependabot bot added 13 commits March 14, 2024 23:34
@dependabot @suprith-hub
Bump tap from 16.3.6 to 16.3.7 (#147)
14c904d 
Bumps [tap](https://github.com/tapjs/node-tap) from 16.3.6 to 16.3.7.
- [Release notes](https://github.com/tapjs/node-tap/releases)
- [Commits](tapjs/tapjs@v16.3.6...v16.3.7)

---
updated-dependencies:
- dependency-name: tap
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump @codemirror/lint from 6.2.2 to 6.3.0 (#146)
ec6f920 
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.2.2 to 6.3.0.
- [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md)
- [Commits](codemirror/lint@6.2.2...6.3.0)

---
updated-dependencies:
- dependency-name: "@codemirror/lint"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump webpack from 5.88.0 to 5.88.1 (#149)
34f4192 
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.0 to 5.88.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.88.0...v5.88.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump @codemirror/lint from 6.3.0 to 6.4.0 (#150)
248ffcd 
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.3.0 to 6.4.0.
- [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md)
- [Commits](codemirror/lint@6.3.0...6.4.0)

---
updated-dependencies:
- dependency-name: "@codemirror/lint"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump word-wrap from 1.2.3 to 1.2.4 (#151)
23d5642 
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump webpack from 5.88.1 to 5.88.2 (#152)
a20a8a5 
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.1 to 5.88.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.88.1...v5.88.2)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump json-e from 4.5.2 to 4.5.3 (#155)
7586d06 
Bumps [json-e](https://github.com/json-e/json-e) from 4.5.2 to 4.5.3.
- [Changelog](https://github.com/json-e/json-e/blob/main/CHANGELOG.rst)
- [Commits](json-e/json-e@v4.5.2...v4.5.3)

---
updated-dependencies:
- dependency-name: json-e
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump bootstrap from 5.3.0 to 5.3.1 (#154)
2f48e44 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.3.0 to 5.3.1.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v5.3.0...v5.3.1)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump tap from 16.3.7 to 16.3.8 (#153)
479e405 
Bumps [tap](https://github.com/tapjs/node-tap) from 16.3.7 to 16.3.8.
- [Release notes](https://github.com/tapjs/node-tap/releases)
- [Commits](tapjs/tapjs@v16.3.7...v16.3.8)

---
updated-dependencies:
- dependency-name: tap
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump @codemirror/lint from 6.4.0 to 6.4.1 (#156)
2a42657 
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.4.0 to 6.4.1.
- [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md)
- [Commits](codemirror/lint@6.4.0...6.4.1)

---
updated-dependencies:
- dependency-name: "@codemirror/lint"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump bootstrap from 5.3.1 to 5.3.2 (#159)
c35ec7e 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.3.1 to 5.3.2.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v5.3.1...v5.3.2)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump @codemirror/lint from 6.4.1 to 6.4.2 (#157)
8489b0c 
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.4.1 to 6.4.2.
- [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md)
- [Commits](codemirror/lint@6.4.1...6.4.2)

---
updated-dependencies:
- dependency-name: "@codemirror/lint"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
@dependabot @suprith-hub
Bump tough-cookie and tap (#160)
119c877 
Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependency [tap](https://github.com/tapjs/tapjs). These dependencies need to be updated together.

Removes `tough-cookie`

Updates `tap` from 16.3.8 to 18.0.3
- [Release notes](https://github.com/tapjs/tapjs/releases)
- [Commits](https://github.com/tapjs/tapjs/compare/[email protected])

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: tap
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Suprith KG <[email protected]>
suprith-hub and others added 16 commits March 14, 2024 23:34
@suprith-hub
TODO: make mappers less verbose
3c304f1 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
updated test-file along with TODO1
a4e5291 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
fixed according to website
3633e68 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
Standards maintained
69b27aa 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
TODO: make mappers less verbose (#177)
835ad41 
Signed-off-by: Suprith KG <[email protected]>
@jviotti @suprith-hub
Revert "TODO: make mappers less verbose (#177)"
acd8c77 
This reverts commit a709674.
@jviotti @suprith-hub
Downgrade Tap to make local testing work again (#179)
aa9fa8a 
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Suprith KG <[email protected]>
@jviotti @suprith-hub
Get rid of Dependabot and CodeQL (#180)
1c4a4e9 
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Suprith KG <[email protected]>
@jviotti @suprith-hub
Split website deployment into a separate action (#181)
e39f5af 
Signed-off-by: Juan Cruz Viotti <[email protected]>
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
TODO: make mappers less verbose
5f039d9 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
updated test-file along with TODO1
c26f69f 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
fixed according to website
0678e25 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
standards maintained2
39e5966
@suprith-hub
standards maintained3
8f51cd9 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
Merge branch 'master' of https://github.com/Era-cell/alterschema_suprith
76e5069
@suprith-hub
Commit last 1
cd9a14a 
Signed-off-by: Suprith KG <[email protected]>
@suprith-hub
Copy link
Contributor Author

suprith-hub commented Mar 15, 2024 •
edited
Loading

Hi, @jviotti it is asking me to resolve all 38 commits which includes your commits too, when I use this command:
git rebase HEAD~39 --signoff
So, Shall I close this and open a new PR? because I dont want to resolve the ones you have changed as it might hamper the things. can I do a new PR closing this

@jviotti
Copy link
Member

jviotti commented Mar 15, 2024

That's weird. I didn't do that many commits. Yes, whatever is easier. Feel free to close and send another one.

@suprith-hub
Copy link
Contributor Author

Looks like its all green, but you need to perform the DCO with Signed-Off-By

Looks like its all green, but you need to perform the DCO with Signed-Off-By

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suprith-hub @jviotti