Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding import symbol roles to occurences created by visiting import … #85

Open
wants to merge 2 commits into
base: scip
Choose a base branch
from

Conversation

maks-ivanov
Copy link

@maks-ivanov maks-ivanov commented May 17, 2023

…related nodes
This is a fix for #84

@@ -485,7 +485,7 @@ export class TreeVisitor extends ParseTreeWalker {
const symbol = this.getScipSymbol(node);
this.document.occurrences.push(
new scip.Occurrence({
symbol_roles: scip.SymbolRole.ReadAccess,
symbol_roles: scip.SymbolRole.Import | scip.SymbolRole.ReadAccess,
Copy link
Author

@maks-ivanov maks-ivanov May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the ReadAccess role is load-bearing in these cases. If not, I would remove those

@maks-ivanov maks-ivanov changed the title adding import symbole roles to occurences created by visiting import … adding import symbol roles to occurences created by visiting import … May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant