Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: building of docker images is more flexible #154

Open
wants to merge 1 commit into
base: scip
Choose a base branch
from

Conversation

kevinvalk
Copy link

This implements #146.

During the refactor I also modernized the build pipeline and Dockerfile with caching, steps, etc. I also use a trick to easily merge base images like node and python into a single image without using something like nikolaik/python-nodejs. However, I did use debian for this as it is more broadly supported on docker images.

I took the liberty to remove the .autoindex suffix from the Dockerfile. However, I did not remove this from the generated docker tags to avoid any breaking changes. That said, it fully overlaps with latest so it could be removed.

Finally, I did the build step using a matrix so in theory different version could be build. Maybe this is early-optimization but o well.

Before this is merged, feel free to use ghcr.io/codean-io/scip-python as your SCIP image if you need the ARM support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant