fixup pipBulkShow function to prevent breaking with numerous names

sourcegraph · May 14, 2023 · 8572b80 · 8572b80
1 parent 8a21e88
commit 8572b80
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/pyright-scip/src/virtualenv/environment.ts b/packages/pyright-scip/src/virtualenv/environment.ts
@@ -33,10 +33,10 @@ function pipList(): PipInformation[] {
 }
 
 function pipBulkShow(names: string[]): string[] {
-    // TODO: This probably breaks with enough names. Should batch them into 512 or whatever the max for bash would be
+    const maxBuffer = 1024 * 1024 * 10; // 10MB
     return child_process
-        .execSync(`${getPipCommand()} show -f ${names.join(' ')}`)
-        .toString()
+        .spawnSync(getPipCommand(), ['show', '-f' ,"${names.join(' ')}"], {maxBuffer})
+        .stdout.toString()
         .split('---');
 }