fix(cody): fix chat context review logic #6602
Open
+96
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression where the agent would mark a context as needed but got filtered out during the validation step - Simplify the context review logic by directly extracting context names from the response and fetching the full content for the requested files. - Remove unnecessary callbacks and optimize the context fetching process. - Add a helper function to check if the response is ready to answer.
abeatrix
requested review from
valerybugakov,
jamesmcnamara,
arafatkatze and
a team
abeatrix
changed the title
arafatkatze
reviewed
Jan 11, 2025
| reviewed.push(...this.context.filter(c => isUserAddedItem(c))) | ||
| // When there are context items matched, we will replace the current context with | ||
| // the reviewed context list, but first we will make sure all the user added context | ||
| // items are nor removed from the updated context list. We will let the prompt builder |
Oh it's been moved out of the model list! Here is a demo: https://sourcegraph.slack.com/archives/C89KCDK5J/p1736447482340629 More context: https://sourcegraph.slack.com/archives/C05MW2TMYAV/p1736536440381029 Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-4671
Fixes a regression where the agent would mark a context as needed but got filtered out during the validation step
Test plan
Manual testing:
Before
Deep Cody requested a file:
But it wasn't included in the final selected context:
After: