Add thread id in ghcide tests log (haskell#4204)

* add threadId to ghcide test * add threadId to ghcide test * add thread id by default in ghcide-tests * remove redundant log
soulomoon · May 4, 2024 · ced09a7 · ced09a7
1 parent 75cb0b9
commit ced09a7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/ghcide/exe/Main.hs b/ghcide/exe/Main.hs
@@ -21,7 +21,7 @@ import qualified Development.IDE.Main                     as IDEMain
 import qualified Development.IDE.Monitoring.OpenTelemetry as OpenTelemetry
 import qualified Development.IDE.Plugin.HLS.GhcIde        as GhcIde
 import           Development.IDE.Types.Options
-import           Ide.Logger                               (LoggingColumn (DataColumn, PriorityColumn),
+import           Ide.Logger                               (LoggingColumn (..),
                                                            Pretty (pretty),
                                                            Priority (Debug, Error, Info),
                                                            WithPriority (WithPriority, priority),
@@ -73,7 +73,7 @@ main = withTelemetryRecorder $ \telemetryRecorder -> do
     -- stderr recorder just for plugin cli commands
     pluginCliRecorder <-
       cmapWithPrio pretty
-      <$> makeDefaultStderrRecorder (Just [PriorityColumn, DataColumn])
+      <$> makeDefaultStderrRecorder (Just [ThreadIdColumn, PriorityColumn, DataColumn])
 
     let hlsPlugins = pluginDescToIdePlugins (GhcIde.descriptors (cmapWithPrio LogGhcIde pluginCliRecorder))
     -- WARNING: If you write to stdout before runLanguageServer

diff --git a/ghcide/test/exe/Main.hs b/ghcide/test/exe/Main.hs
@@ -49,6 +49,7 @@ import           CompletionTests
 import           CPPTests
 import           CradleTests
 import           DependentFileTest
+import           Development.IDE              (LoggingColumn (..))
 import           DiagnosticTests
 import           ExceptionTests
 import           FindDefinitionAndHoverTests
@@ -74,7 +75,7 @@ import           WatchedFileTests
 
 main :: IO ()
 main = do
-  docWithPriorityRecorder <- makeDefaultStderrRecorder (Just [PriorityColumn, DataColumn])
+  docWithPriorityRecorder <- makeDefaultStderrRecorder (Just [ThreadIdColumn, PriorityColumn, DataColumn])
 
   let docWithFilteredPriorityRecorder =
         docWithPriorityRecorder

diff --git a/hls-test-utils/src/Test/Hls/FileSystem.hs b/hls-test-utils/src/Test/Hls/FileSystem.hs
@@ -115,7 +115,6 @@ materialise rootDir' fileTree testDataDir' = do
       copyDir' root dir = do
         files <- fmap FP.normalise . lines <$> withCurrentDirectory (testDataDir </> dir) (readProcess "git" ["ls-files", "--cached", "--modified", "--others"] "")
         mapM_ (createDirectoryIfMissing True . ((root </>) . takeDirectory)) files
-        mapM_ (\f -> putStrLn $ (testDataDir </> dir </> f) <> ":" <> (root </> f) ) files
         mapM_ (\f -> copyFile (testDataDir </> dir </> f) (root </> f)) files
         return ()