Batch load multi read #190
Annotations
15 warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Checking code:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L624
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "return\n $ (this_options, \n Set.fromList $ fromNormalizedFilePath <$> newLoaded)" ▫︎ Perhaps: "return\n (this_options, Set.fromList $ fromNormalizedFilePath <$> newLoaded)"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L675
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' cradle_files (\\ xs -> (newLoaded <> xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((<>) newLoaded)"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L685
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "if (not $ null attemptToLoadFiles) then\n do let failedLoadingFiles = (Set.insert cfp attemptToLoadFiles)\n atomicModifyIORef'\n error_loading_files (\\ xs -> (failedLoadingFiles <> xs, ()))\n logWith recorder Info\n $ LogSessionReloadOnError cfp (Set.toList attemptToLoadFiles)\n consultCradle hieYaml cfp\nelse\n do dep_info <- getDependencyInfo\n ((maybeToList hieYaml) ++ concatMap cradleErrorDependencies err)\n let ncfp = toNormalizedFilePath' cfp\n let res\n = (map (\\ err' -> renderCradleError err' cradle ncfp) err, Nothing)\n atomically $ S.delete cfp pendingFileSet\n atomically\n $ do STM.focus\n (Focus.insertOrMerge HM.union (HM.singleton ncfp (res, dep_info)))\n hieYaml fileToFlags\n STM.insert hieYaml ncfp filesMap\n atomicModifyIORef'\n error_loading_files (\\ xs -> (Set.insert cfp xs, ()))\n return (res, dep_info)" ▫︎ Perhaps: "if not $ null attemptToLoadFiles then\n do let failedLoadingFiles = (Set.insert cfp attemptToLoadFiles)\n atomicModifyIORef'\n error_loading_files (\\ xs -> (failedLoadingFiles <> xs, ()))\n logWith recorder Info\n $ LogSessionReloadOnError cfp (Set.toList attemptToLoadFiles)\n consultCradle hieYaml cfp\nelse\n do dep_info <- getDependencyInfo\n ((maybeToList hieYaml) ++ concatMap cradleErrorDependencies err)\n let ncfp = toNormalizedFilePath' cfp\n let res\n = (map (\\ err' -> renderCradleError err' cradle ncfp) err, Nothing)\n atomically $ S.delete cfp pendingFileSet\n atomically\n $ do STM.focus\n (Focus.insertOrMerge HM.union (HM.singleton ncfp (res, dep_info)))\n hieYaml fileToFlags\n STM.insert hieYaml ncfp filesMap\n atomicModifyIORef'\n error_loading_files (\\ xs -> (Set.insert cfp xs, ()))\n return (res, dep_info)"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L692
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "do let failedLoadingFiles = (Set.insert cfp attemptToLoadFiles)\n atomicModifyIORef'\n error_loading_files (\\ xs -> (failedLoadingFiles <> xs, ()))\n logWith recorder Info\n $ LogSessionReloadOnError cfp (Set.toList attemptToLoadFiles)\n consultCradle hieYaml cfp" ▫︎ Perhaps: "do let failedLoadingFiles = Set.insert cfp attemptToLoadFiles\n atomicModifyIORef'\n error_loading_files (\\ xs -> (failedLoadingFiles <> xs, ()))\n logWith recorder Info\n $ LogSessionReloadOnError cfp (Set.toList attemptToLoadFiles)\n consultCradle hieYaml cfp"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L693
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n error_loading_files (\\ xs -> (failedLoadingFiles <> xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ error_loading_files ((<>) failedLoadingFiles)"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L698
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(maybeToList hieYaml) ++ concatMap cradleErrorDependencies err" ▫︎ Perhaps: "maybeToList hieYaml ++ concatMap cradleErrorDependencies err"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L706
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n error_loading_files (\\ xs -> (Set.insert cfp xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ error_loading_files (Set.insert cfp)"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L742
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> (Set.empty, ())" ▫︎ Perhaps: "const (Set.empty, ())"
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L743
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> (Set.empty, ())" ▫︎ Perhaps: "const (Set.empty, ())"
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading