Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool info for validator Witch #953

Closed
wants to merge 2 commits into from
Closed

Conversation

ayazip
Copy link

@ayazip ayazip commented Nov 2, 2023

Add tool info for YAML violation witness validator Witch

Add tool info for YAML witness validator Witch
@PhilippWendler
Copy link
Member

@ayazip
Copy link
Author

ayazip commented Nov 2, 2023

@PhilippWendler
I could, but I am not sure how to then specify that Witch should use this module. The verifiers have this info in the fm-tools repository, but the validators don't have this.

I guess that it would it be enough to put "symbiotic-witch" as the tool name in the benchmark definition file for Witch, but I am not sure. Please confirm that this is the case; if it is, I will change it and close this PR.

@PhilippWendler
Copy link
Member

PhilippWendler commented Nov 2, 2023

I could, but I am not sure how to then specify that Witch should use this module. The verifiers have this info in the fm-tools repository, but the validators don't have this.

For questions about the FM-Tools-Repository, please ask there. But AFAIK a tool listed there can point to its tool-info module with the benchexec_toolinfo_module key. For example, CPAchecker does so (and it is both a verifier and a validator).

I guess that it would it be enough to put "symbiotic-witch" as the tool name in the benchmark definition file for Witch, but I am not sure. Please confirm that this is the case; if it is, I will change it and close this PR.

The tool attribute of the benchmark tag in the benchmark definition determines which tool-info module BenchExec uses, yes.

@ayazip
Copy link
Author

ayazip commented Nov 2, 2023

Great, thanks!

@ayazip ayazip closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants