Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s example: use podManagementPolicy: Parallel #708

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drdivano
Copy link

@drdivano drdivano commented Oct 5, 2019

This change allows cluster to recover during partial storage failure by preventing the following situation:

  1. We run Stolon as a StatefulSet with 2 or more replicas
  2. The cluster goes down together with storage system
  3. The cluster comes up. The storage system comes up partially, with Persistent Volume 0 still unavailable.
  4. Kubernetes fails to re-schedule and start the StatefulSet since storage for replica 0 is still down.

The Parallel policy tells Kubernetes to start other replicas without waiting for replicas with lower ordinal numbers.

@sgotti
Copy link
Member

sgotti commented Oct 8, 2019

@drdivano Thanks for the PR!. Since it's related to just the k8s example can you rename it to k8s example: use podManagementPolicy: Parallel

And then in the description describe why it's useful.

@sgotti sgotti self-requested a review October 8, 2019 07:44
@drdivano drdivano changed the title Allow cluster to recover during partial storage failure k8s example: use podManagementPolicy: Parallel Oct 8, 2019
Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drdivano Thanks for the PR!. Since it's related to just the k8s example can you rename it to k8s example: use podManagementPolicy: Parallel

And then in the description describe why it's useful.

@drdivano
Copy link
Author

@drdivano Thanks for the PR!. Since it's related to just the k8s example can you rename it to k8s example: use podManagementPolicy: Parallel

And then in the description describe why it's useful.

@sgotti I renamed the PR and added a description as you asked 13 days ago. Did I misunderstand you?

@sgotti
Copy link
Member

sgotti commented Oct 21, 2019

@sgotti I renamed the PR and added a description as you asked 13 days ago. Did I misunderstand you?

Sorry, I just lost your push. Can you please rebase in a single commit instead of merging master branch (for a cleaner git history)? Thanks.

@sgotti sgotti self-requested a review November 28, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants