-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: add feedback for require_privmsg
commands
#2641
base: master
Are you sure you want to change the base?
Conversation
I think this could go farther. Several more commands expect to be run in PM, but don't give feedback (e.g. Also, the decorator order here now matters. If That's what we were talking about on IRC, is to have feedback about Huh, unexpectedly it's nice to have a chance to iterate on something without wasting GHA minutes… Wonder if we can treat everyone as a new contributor, even me? |
require_privmsg
commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said before (emphasis added):
That's what we were talking about on IRC, is to have feedback about
require_privmsg
for these admin commands but only if the user is already authorized to use them. Normal users shouldn't get any response
Changed @plugin.require_admin to be silent if called by an unauthorized user. |
5f34d10
to
819e874
Compare
Co-authored-by: dgw <[email protected]>
Modified a lot since, and I'm now a co-author so someone else should be the approver
Previously .say, .me and .raw didn't provide feedback in the channel of usage to the user but silently just did nothing.