Merge "diag: Prevent using uninitialized mdlog session mask"

sonyxperiadev · Jul 3, 2019 · d05a251 · d05a251
2 parents a92c2f5 + c7a160e
commit d05a251
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/drivers/char/diag/diagchar_core.c b/drivers/char/diag/diagchar_core.c
@@ -449,7 +449,7 @@ void diag_clear_masks(int pid)
 static void diag_close_logging_process(const int pid)
 {
 	int i, j;
-	int session_mask;
+	int session_mask = 0;
 	int device_mask = 0;
 	uint32_t p_mask;
 	struct diag_md_session_t *session_info = NULL;
@@ -473,8 +473,9 @@ static void diag_close_logging_process(const int pid)
 		diag_clear_masks(pid);
 
 	mutex_lock(&driver->diagchar_mutex);
-	p_mask =
-	diag_translate_kernel_to_user_mask(session_mask);
+	if (session_mask)
+		p_mask =
+		diag_translate_kernel_to_user_mask(session_mask);
 
 	for (i = 0; i < NUM_MD_SESSIONS; i++)
 		if (MD_PERIPHERAL_MASK(i) & session_mask)