Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slog warning #418

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix slog warning #418

wants to merge 2 commits into from

Conversation

lo-simon
Copy link
Contributor

Use char* for slog::log to prevent warning.

@garethsb
Copy link
Contributor

garethsb commented Nov 21, 2024

Were you able to work out why this overload doesn't work in this case?

inline log_statement& operator<<(log_statement& s, const utf16string& u16s)

@garethsb garethsb mentioned this pull request Nov 22, 2024
@lo-simon
Copy link
Contributor Author

Were you able to work out why this overload doesn't work in this case?

inline log_statement& operator<<(log_statement& s, const utf16string& u16s)

The overload does work, but I keep getting the following warning,
warning C4239: nonstandard extension used: argument: conversion from slog::detail::anonymous-namespace::log<slog::base_gate,20> to slog::log_statement & that why I made the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants