Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isRunning: check if process is still running #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

isRunning: check if process is still running #2

wants to merge 2 commits into from

Conversation

Piratmac
Copy link

No description provided.

@Piratmac
Copy link
Author

This should fix #1

bdsoha
bdsoha reviewed Mar 15, 2023
View reviewed changes
Copy link

@bdsoha bdsoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for if/else when there is an early return.

index.js Outdated Show resolved Hide resolved
@Piratmac @bdsoha
Removed unnecessary "if"
d36841d 
Co-authored-by: Dov Benyomin Sohacheski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdsoha bdsoha bdsoha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piratmac @bdsoha