Add recover hardware config if load golden config. #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xincunli-sonic
requested review from
wen587,
rlhui,
judyjoseph,
arlakshm and
abdosi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Restore hardware related configuration:
asic_id,macandplatformfrom local file since the golden config does not have them.How I did it
Add a function to backfill these fields
asic_id,macandplatformto config db by read local files afterload golden config.How to verify it
Using lab device to download golden config which does not have these fields, and apply through load_minigraph with overridde golden config option, then check configdb dump if they get populated correctly.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)