[show][interfaces] Add proposal for show interfaces flap #3627
Conversation
Signed-off-by: Vaibhav Dahiya <[email protected]>
Signed-off-by: Vaibhav Dahiya <[email protected]>
vdahiya12
changed the title
Signed-off-by: Vaibhav Dahiya <[email protected]>
There was a problem hiding this comment.
@vdahiya12 can
- Link down timestamp as "Last flapped : 2024-10-01 10:00:00 UTC (0 days 00:01:23 ago)
- Link up timestamp as "Last Link up: 2024-10-05 10:01:03 UTC (5 days 02:30 :15 ago)
There was a problem hiding this comment.
@vdahiya12 you can specify the column for timestamp (UTC).
There was a problem hiding this comment.
I did not understand the logic here, do we want one or two columns? If we say just one column then how will both last flap and last link up be supported.
Also if we support both, the first time switch boots up and the link never comes up, then last link down should be boot time ? and last link up be never ?
There was a problem hiding this comment.
is this what is expected ?
admin@sonic:~$ show interfaces flap
Interface Link Down TimeStamp (UTC) Link Up TimeStamp (UTC) Flap Count
--------- ------------------------------------------------------- ----------------------------------------------------------- ----------
Ethernet0 Last flapped : 2024-10-01 10:00:00 (0 days 00:01:23 ago) Last Link up: 2024-09-30 10:01:03 UTC (1 days 02:30 :15 ago) 5
Ethernet4 Never Last Link up: 2024-09-30 10:01:03 UTC (1 days 02:30 :15 ago) Never
Ethernet8 Last flapped : 2024-10-01 10:01:00 (0 days 00:00:23 ago) Last Link up: 2024-10-02 10:01:03 UTC (5 days 02:30 :15 ago) 1
There was a problem hiding this comment.
@vdahiya12 LGTM. Nit: We don't need to mention "Last flapped" or "Lask Link up" as the column name already mentions that
|
@vdahiya12 If the link down count = 0 or the link up count = 0 then the timestamp should show "never". can you capture these? |
doc/Command-Reference.md
Outdated
| --------- ------------------- ---------- | ||
| Ethernet0 2024-11-21 14:32:12 5 | ||
| Ethernet4 2024-11-20 08:15:04 2 | ||
| Ethernet8 2024-11-19 23:45:16 8 |
There was a problem hiding this comment.
@vdahiya12 show one example where link never flapped
There was a problem hiding this comment.
added for Ethernet4
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
/azp run |
|
Pull request contains merge conflicts. |
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prgeor please approve |
The show interfaces flap command provides detailed insights into interface events, including the timestamp of the last link down event and the total flap count (number of times the link has gone up and down). This helps in diagnosing stability and connectivity issues.
What I did
added documentation for show interfaces flap with a detailed output
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)