Set the execute bit on sysDescr_pass.py #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the execute bit on the script in git instead of relying on a deployment script later to set the bit.
|
|
|
This seems like a work around, because with the slim image loaded, I was able to run a python script inside snmp docker to copy the sysDescr_pass.py to the location and change the mode to allow execution. What is the reason that we are able to do it during run time but does not occur when sonic_ax_impl comes up? |
|
hi @SuvarnaMeenakshi I plan to take this as a workaround for now.
let me know if any concern. |
SuvarnaMeenakshi
approved these changes
Jan 17, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-snmpagent
that referenced
this pull request
Jan 17, 2024
#### Why I did it Slim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact. #### How I did it Set the execute bit directly within source control #### How to verify it Testing on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.
|
Cherry-pick PR to 202305: #307 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
#### Why I did it Slim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact. #### How I did it Set the execute bit directly within source control #### How to verify it Testing on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-snmpagent
that referenced
this pull request
Feb 2, 2024
#### Why I did it Slim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact. #### How I did it Set the execute bit directly within source control #### How to verify it Testing on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.
|
Cherry-pick PR to 202311: #311 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
#### Why I did it Slim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact. #### How I did it Set the execute bit directly within source control #### How to verify it Testing on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Slim images may have a sysDescr_pass.py script that does not correctly have the execute bit set resulting in any request for the sysDescr.0 OID via SNMP would fail. By setting the execute bit directly in source control, this script is no longer reliant on any deployment script to fix the permissions after the fact.
How I did it
Set the execute bit directly within source control
How to verify it
Testing on a platform which uses a slim image should reliably pass the snmp/test_snmp_v2mib.py test.
Which release branch to backport (provide reason below if selected)