Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for IfHighSpeed with PortChannel with no member ports #296

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Oct 8, 2023

Add unit test for IfHighSpeed with PortChannel with no member ports

Work item tracking

Microsoft ADO (number only): 25199873

- What I did
Add new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: #294

- How I did it
Add new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports

- How to verify it
Pass all UT

- Description for the changelog
Add unit test of IfHighSpeed with PortChannel with no member ports

@liuh-80 liuh-80 force-pushed the dev/liuh/if_high_speed_ut branch from a8b24f7 to 63ca5db Compare October 8, 2023 09:14
@liuh-80 liuh-80 marked this pull request as ready for review October 8, 2023 09:18
@liuh-80 liuh-80 requested a review from qiluo-msft October 8, 2023 09:18
@liuh-80 liuh-80 changed the title Add unit test of IfHighSpeed with PortChannel with no member ports Add unit test for IfHighSpeed with PortChannel with no member ports Oct 8, 2023
@qiluo-msft qiluo-msft merged commit bdaddca into sonic-net:master Oct 10, 2023
4 checks passed
qiluo-msft pushed a commit that referenced this pull request Oct 10, 2023
Add unit test for IfHighSpeed with PortChannel with no member ports

#### Work item tracking
Microsoft ADO (number only): 25199873

**- What I did**
Add new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: #294

**- How I did it**
Add new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports

**- How to verify it**
Pass all UT

**- Description for the changelog**
Add unit test of IfHighSpeed with PortChannel with no member ports
yxieca pushed a commit that referenced this pull request Oct 13, 2023
Add unit test for IfHighSpeed with PortChannel with no member ports

#### Work item tracking
Microsoft ADO (number only): 25199873

**- What I did**
Add new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: #294

**- How I did it**
Add new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports

**- How to verify it**
Pass all UT

**- Description for the changelog**
Add unit test of IfHighSpeed with PortChannel with no member ports
StormLiangMS pushed a commit that referenced this pull request Oct 17, 2023
Add unit test for IfHighSpeed with PortChannel with no member ports

#### Work item tracking
Microsoft ADO (number only): 25199873

**- What I did**
Add new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: #294

**- How I did it**
Add new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports

**- How to verify it**
Pass all UT

**- Description for the changelog**
Add unit test of IfHighSpeed with PortChannel with no member ports
qiluo-msft pushed a commit that referenced this pull request Oct 20, 2023
Add unit test for IfHighSpeed with PortChannel with no member ports

#### Work item tracking
Microsoft ADO (number only): 25199873

**- What I did**
Add new UT cover InterfaceMIBUpdater.get_high_speed(), this will fix issue: #294

**- How I did it**
Add new UT and mock data to test InterfaceMIBUpdater.get_high_speed() with PortChannel with no member ports

**- How to verify it**
Pass all UT

**- Description for the changelog**
Add unit test of IfHighSpeed with PortChannel with no member ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants