Issue #138: Fix instability in test_vxlan_ecmp sonic-mgmt test #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkeelAli
approved these changes
Dec 6, 2024
|
Hey, we have PR sonic-net/sonic-sairedis#1473 that have move src from sonic-platform-vpp to virtual switch in sairedis but its not compiling yet, since we dont have pipeline setup in this repo to produce deb packages and i alreayd saw taht you are adding new changes here which get out of sync + @lguohan this change is not synced to my PR, and i thought we agreed that new features will be added on sairedis repo ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Addressing issue #138:
test_vxlan_ecmp sonic-mgmt test failed occasionally. This is because vl_api_bfd_udp_session_event_t_handler calls set_reply_status. The callback is for unsolicited event (bfd state update). set_reply_status should not be called for unsolicited event and it can mess up other requests. In our case, it is vxlan tunnel create request.
In the long run, we should make request/response more robust by setting request_message_id in the context of request to match its response.
What this PR does
remove set_reply_status from vl_api_bfd_udp_session_event_t_handler
Also fixed bridge domain ID resource leak. BD ID is not put back to the resource pool when vxlan decap is deleted.