Remove lane speed key construction failure log #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidZagury
approved these changes
Oct 20, 2024
prgeor
previously approved these changes
Oct 20, 2024
|
@tshalvi can you do a force push to re-trigger the checks? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…s key type is not mandatory for all vendors
prgeor
approved these changes
Oct 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tshalvi
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Dec 10, 2024
* Reduce log level for lane speed key construction failure * Removed the lane speed key construction failure log completely as this key type is not mandatory for all vendors
|
Cherry-pick PR to 202405: #571 |
|
@kperumalbfn Please handle the cherry-pick to 202411 branch |
|
Thanks @bingwang-ms This PR is already part of 202411. |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Reduce log level for lane speed key construction failure * Removed the lane speed key construction failure log completely as this key type is not mandatory for all vendors
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the lane_speed key construction failure log from media_settings_parser.
Motivation and Context
The lane_speed_key is one of the key types used for the media_settings.json lookup.
This type of key is not relevant for all vendors, and thus it is not mandatory.
After some discussion, it was decided to completely remove this error log.
How Has This Been Tested?
Additional Information (Optional)