Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 800G ifname in xcvrd #416

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Support 800G ifname in xcvrd #416

merged 2 commits into from
Dec 21, 2023

Conversation

AnoopKamath
Copy link
Contributor

@AnoopKamath AnoopKamath commented Dec 20, 2023 •
edited
Loading

Description

Add 800G ifname in xcvrd get_interface_speed() which gets the port speed from the host interface name.

Motivation and Context

How Has This Been Tested?

Verified with enabling 800G module app code

202305 commit PR: #420

Additional Information (Optional)

@AnoopKamath
Copy link
Contributor Author

@prgeor, @mihirpat1 , Please review this

prgeor
prgeor previously approved these changes Dec 20, 2023
View reviewed changes
mihirpat1
mihirpat1 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mihirpat1 mihirpat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the code coverage failure.

@prgeor prgeor added the xcvrd label Dec 21, 2023
@prgeor prgeor merged commit b1e51c3 into sonic-net:master Dec 21, 2023
5 checks passed
@mihirpat1
Copy link
Contributor

@StormLiangMS @yxieca - Can you please help to cherry-pick this to 202305 and 202311?
MSFT ADO - 26246820

@StormLiangMS
Copy link

hi @mihirpat1 why we need this for 202305? there is no 800G product in 202305.

@mihirpat1
Copy link
Contributor

hi @mihirpat1 why we need this for 202305? there is no 800G product in 202305.

@AnoopKamath - Can you please help in responding to @StormLiangMS.

@AnoopKamath
Copy link
Contributor Author

Hi @StormLiangMS, we are already supporting 800G in 2x400G mode and want to enable 800G app code now in 202305. @prgeor can add more details.
This HLD https://github.com/sonic-net/SONiC/blob/master/doc/sfp-cmis/CMIS-custom-SI-settings.md was also added which is required to support certain 800G modules.

@prgeor, @mihirpat1, Can you please review and help merge double commit these changes to 202305? #420

@AnoopKamath AnoopKamath mentioned this pull request Jan 9, 2024
Merged
@AnoopKamath
Copy link
Contributor Author

Hi @StormLiangMS, can you please cherry pick this to 202311?

mssonicbld pushed a commit to mssonicbld/sonic-platform-daemons that referenced this pull request Feb 2, 2024
@AnoopKamath @mssonicbld
Support 800G ifname in xcvrd (sonic-net#416)
e9696ae 
* Support 800G iframe in xcvrd

* Add code coverage
@mssonicbld mssonicbld mentioned this pull request Feb 2, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #429

mssonicbld pushed a commit that referenced this pull request Feb 2, 2024
@AnoopKamath @mssonicbld
Support 800G ifname in xcvrd (#416)
dbaa079 
* Support 800G iframe in xcvrd

* Add code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirpat1 mihirpat1 mihirpat1 approved these changes

@prgeor prgeor prgeor approved these changes

Assignees
No one assigned
Labels
Approved for 202305 Branch Approved for 202311 Branch Cherry Pick Conflict_202305 Included in 202311 Branch Request for 202305 Branch Request for 202311 Branch xcvrd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnoopKamath @mihirpat1 @StormLiangMS @mssonicbld @prgeor @yxieca