-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
400ZR not linking up with latest SONiC master image #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <[email protected]>
@tshalvi - Can you please help in reviewing this? |
Signed-off-by: Mihir Patel <[email protected]>
…-daemons into 400zr_link_down
prgeor
approved these changes
Dec 7, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Feb 2, 2024
* 400ZR not linking up with latest SONiC master image Signed-off-by: Mihir Patel <[email protected]> * 400ZR not linking up with latest SONiC master image Signed-off-by: Mihir Patel <[email protected]> * Added testcase to improve code coverage --------- Signed-off-by: Mihir Patel <[email protected]>
Cherry-pick PR to 202311: #428 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
* 400ZR not linking up with latest SONiC master image Signed-off-by: Mihir Patel <[email protected]> * 400ZR not linking up with latest SONiC master image Signed-off-by: Mihir Patel <[email protected]> * Added testcase to improve code coverage --------- Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the latest SONiC image, the link on 400ZR remains down.
Motivation and Context
The issue seems to have been introduced via #400
The is_cmis_api API currently returns False for CCmis modules. Hence, the CMIS SM doesn't identify 400ZR and skips the port initialization as the desired application id is returned as None.
sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py
Lines 134 to 135 in 502c0b6
How Has This Been Tested?
Link up on 400ZR has been verified after switch boot-up.
Additional Information (Optional)
MSFT ADO - 26098607