Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400ZR not linking up with latest SONiC master image #410

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Dec 7, 2023

Description

With the latest SONiC image, the link on 400ZR remains down.

Motivation and Context

The issue seems to have been introduced via #400

The is_cmis_api API currently returns False for CCmis modules. Hence, the CMIS SM doesn't identify 400ZR and skips the port initialization as the desired application id is returned as None.

if not is_cmis_api(api):
return None

How Has This Been Tested?

Link up on 400ZR has been verified after switch boot-up.

root@sonic:/home/admin# show int status Ethernet144
  Interface                            Lanes    Speed    MTU    FEC         Alias    Vlan    Oper    Admin                                             Type    Asym PFC
-----------  -------------------------------  -------  -----  -----  ------------  ------  ------  -------  -----------------------------------------------  ----------
Ethernet144  145,146,147,148,149,150,151,152     400G   9100    N/A  Ethernet19/1  routed      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
root@sonic:/home/admin# show int status Ethernet160
  Interface                            Lanes    Speed    MTU    FEC         Alias    Vlan    Oper    Admin                                             Type    Asym PFC
-----------  -------------------------------  -------  -----  -----  ------------  ------  ------  -------  -----------------------------------------------  ----------
Ethernet160  161,162,163,164,165,166,167,168     400G   9100    N/A  Ethernet21/1  routed      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
root@sonic:/home/admin# show lldp table
Capability codes: (R) Router, (B) Bridge, (O) Other
LocalPort    RemoteDevice                  RemotePortID    Capability    RemotePortDescr
-----------  ----------------------------  --------------  ------------  ------------------------
Ethernet144  sonic                         Ethernet21/1    BR            Ethernet160
Ethernet160  sonic                         Ethernet19/1    BR            Ethernet144
--------------------------------------------------
Total entries displayed:  2
root@sonic:/home/admin# 

Additional Information (Optional)

MSFT ADO - 26098607

@mihirpat1 mihirpat1 requested a review from prgeor December 7, 2023 05:29
@mihirpat1
Copy link
Contributor Author

@tshalvi - Can you please help in reviewing this?

@mihirpat1 mihirpat1 marked this pull request as draft December 7, 2023 05:44
@mihirpat1 mihirpat1 marked this pull request as ready for review December 7, 2023 17:21
@prgeor prgeor merged commit 1c9b01d into sonic-net:master Dec 7, 2023
5 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-platform-daemons that referenced this pull request Feb 2, 2024
* 400ZR not linking up with latest SONiC master image

Signed-off-by: Mihir Patel <[email protected]>

* 400ZR not linking up with latest SONiC master image

Signed-off-by: Mihir Patel <[email protected]>

* Added testcase to improve code coverage

---------

Signed-off-by: Mihir Patel <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #428

mssonicbld pushed a commit that referenced this pull request Feb 2, 2024
* 400ZR not linking up with latest SONiC master image

Signed-off-by: Mihir Patel <[email protected]>

* 400ZR not linking up with latest SONiC master image

Signed-off-by: Mihir Patel <[email protected]>

* Added testcase to improve code coverage

---------

Signed-off-by: Mihir Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants