Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative case for pci_detach() and pci_reattach() #504

Merged
merged 7 commits into from
Nov 9, 2024
Merged

Add negative case for pci_detach() and pci_reattach() #504

merged 7 commits into from
Nov 9, 2024

Conversation

vvolam
Copy link
Contributor

@vvolam vvolam commented Oct 9, 2024 •
edited
Loading

Address the comments added in #501

Description

  • Add negative for pci_detach() and pci_reattach()
  • Remove module_name from get_bus_info(), pci_reattach() and pci_detach()
  • Add MODULE_TYPE_SMARTSWITCH to reboot API. This reboot_type is used for rebooting DPUs when entire smartswitch undergoes for a reboot.
  • Also fix unittests accordingly.

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

@vvolam vvolam mentioned this pull request Oct 9, 2024
Merged
@vvolam vvolam mentioned this pull request Oct 9, 2024
Merged
@vvolam
Add negative case for pci_detach()
1f59217 
Also, remove module_name from pci_detach() and get_bus_info()
@vvolam vvolam changed the title Add negative case for pci_attach() and pci_reattach() Add negative case for pci_detach() Nov 4, 2024
@vvolam vvolam requested review from rameshraghupathy and gpunathilell and removed request for gpunathilell November 4, 2024 14:53
@prgeor
Copy link
Collaborator

prgeor commented Nov 5, 2024

@vvolam please add more details in the PR description.

@oleksandrivantsiv oleksandrivantsiv mentioned this pull request Nov 6, 2024
Open
@vvolam vvolam changed the title Add negative case for pci_detach() Add negative case for pci_detach() and pci_reattach() Nov 8, 2024
rameshraghupathy
rameshraghupathy reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@rameshraghupathy rameshraghupathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

sonic_platform_base/module_base.py Show resolved Hide resolved
@prgeor prgeor merged commit e79279b into sonic-net:master Nov 9, 2024
5 checks passed
@vvolam vvolam deleted the ss-reboot branch November 9, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameshraghupathy rameshraghupathy rameshraghupathy approved these changes

@prgeor prgeor prgeor approved these changes

@gpunathilell gpunathilell Awaiting requested review from gpunathilell

@oleksandrivantsiv oleksandrivantsiv Awaiting requested review from oleksandrivantsiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vvolam @prgeor @oleksandrivantsiv @rameshraghupathy @gpunathilell