-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMIS] Add lane_mask parameter to set_loopback_mode() to enable setti… #490
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36a0294
[CMIS] Add lane_mask parameter to set_loopback_mode() to enable setti…
xinyulin b2ac81c
[CMIS] Add options to individually clear host/media, input/output loo…
xinyulin 6801fa0
[CMIS] Reject the loopback mode request if simultaneous host and medi…
xinyulin 7105a22
[CMIS] Log errors for all set loopback mode rejection cases
xinyulin dd39936
[CMIS] Improve readability by using individual functions for setting …
xinyulin 9faee1a
[CMIS] Add an enable parameter to eliminate the need for loopback mod…
xinyulin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinyulin As part of clearing the loopback (line 1136-1140), can we make sure that the loopback is cleared only for the lane_mask lanes rather than all lanes?
Also, should we check if the module advertises per lane loopback support and then use
lane_mask
accordingly. This will be helpful to clear loopback on all lanes if per lane loopback is not supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none
mode, we will need to have two lane masks (host_lane_mask
andmedia_lane_mask
for host and media individually) because the host and media lane masks might not be identical (e.g., host_lane_mask = 0x3, media_lane_mask = 0x1).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinyulin
For
2.
, we can expectloopback_mode
to include the type of loopback to be cleared i.e. havehost-side-input-none
,host-side-output-none
etc. In this case, the caller can pass the lane_mask accordingly.For
3.
, I think we should configure entire physical port and display a message. @prgeor Can you please confirm the expected behavior in this case?For
4.
, Yes, I think it is helpful to log messages in reject cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihirpat1 Thanks for the comments. I've updated it accordingly. Let's check if Prince has any comments on the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinyulin I discussed with @prgeor regarding
3.
and concluded to reject the config if per lane loopback is not supported (i.e. we should not configure unrelated lanes when loopback is intended to configure specific lanes).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihirpat1 Thanks for the confirmation. It has been updated!