Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component]Fix test_get_firmware_update_notification fail #472

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sonic_platform_base/component_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def get_firmware_update_notification(self, image_path):
A string containing the component firmware update notification if required.
By default 'None' value will be used, which indicates that no actions are required
"""
return None
return 'None'

def install_firmware(self, image_path):
"""
Expand Down
7 changes: 7 additions & 0 deletions tests/component_base_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from sonic_platform_base.component_base import ComponentBase

class TestComponentBase:

def test_get_firmware_update_notification(self):
cpnt = ComponentBase()
assert(cpnt.get_firmware_update_notification(None) == "None")
Loading