Add redis ACL support #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
liat-grozovik
changed the title
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
When sysfs is simultaneously changing while psud updating, some data could be outdated immediately once read, so delay the psu presence and status updating to the final step, insure we get the latest info.
Description
PSU Model Serial HW Rev Voltage (V) Current (A) Power (W) Status LED
PSU 1 N/A N/A N/A 12.00 N/A N/A OK green
PSU 2 XXXXXXX XXXXXXXX A3 12.01 16.25 194.75 OK green
The status should be NOTOK as the psu had been turned off and other fields had became N/A as expected.
Motivation and Context
The failure flow are showing below:
psu_db_update(self.psu_tbl, self.num_psus) // here we read and update the old data of psu status.
self.update_psu_data() // now psu status had been changed to NOTOK, but we won’t read it until next psu update cycle , other filed becomes N/A as expected.
How Has This Been Tested?
platform_tests/api/test_psu.py
Signed-off-by: Yuanzhe, Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Redis ACL support
All the PR related can be found in the description of this PR:
sonic-net/sonic-buildimage#17577
Motivation and Context
Enhance Redis Security
How Has This Been Tested?
Can be tested with the instructions in the PR mentioned in the description chapter.
Additional Information (Optional)