Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch #123

Open
wants to merge 1 commit into
base: 201811
Choose a base branch
from
Open

[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch #123

wants to merge 1 commit into from

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Sep 30, 2020 •
edited
Loading

[Transceiver] Add parser for QSFP-DD cable type and dictionaries for QSFP-DD codes

Picking a change from: 9e3c2da

  • Add parser for QSFP-DD cable type.
  • Add dictionaries for QSFP-DD codes.

Test result: transceiver_info_dom.log

Signed-off-by: Wirut Getbamrung [email protected]

@shlomibitton
[Transceiver] Add parser for QSFP-DD cable type and dictionaries for …
9e3c2da 
…QSFP-DD codes (sonic-net#101)

- Add parser for QSFP-DD cable type.
- Add dictionaries for QSFP-DD codes.

Signed-off-by: Shlomi Bitton <[email protected]>
@zhenggen-xu
Copy link

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@mudsut4ke
Copy link
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

@zhenggen-xu
Copy link

zhenggen-xu commented Oct 8, 2020 •
edited
Loading

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@mudsut4ke
Copy link
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

@zhenggen-xu
Copy link

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

@mudsut4ke
Copy link
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,
So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

@zhenggen-xu , Sure, I will do

@zhenggen-xu
Copy link

Did you make any changes other than #101?
If not, we should cherry-pick that into 201811 without a new PR.

@mudsut4ke
Copy link
Contributor Author

@zhenggen-xu , no change
I just cherry-pick commit from #101

@mudsut4ke
Copy link
Contributor Author

@zhenggen-xu , Can you merge this one ?

@jleveque jleveque requested a review from lguohan November 4, 2020 18:46
@jleveque
Copy link
Contributor

jleveque commented Nov 4, 2020

@lguohan: This PR introduces a new feature to the stable 201811 branch. What are your feelings?

@prgeor
Copy link
Collaborator

prgeor commented Jul 27, 2022

@mudsut4ke can we close this PR?

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@zzhiyuan
[xcvrd] Fix xcvrd crash on other port prefixes (sonic-net#123)
b9381a5 
Implement a better check for logical_port_name_to_physical_port_list function.

Currently it will only accept names that start with "Ethernet". If we try to add other ports it will crash.

In the future Arista will implement other port types. For example "Recirc0".

Co-authored-by: Zhi Yuan Carl Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan Awaiting requested review from lguohan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mudsut4ke @zhenggen-xu @jleveque @prgeor @shlomibitton