Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize test_snmp_fdb_send_tagged #16409

Merged

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jan 9, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

test_snmp_fdb_send_tagged is flaky on dualtor testbed.

Signed-off-by: Longxiang Lyu [email protected]

How did you do it?

Two improvements:

  1. flush fdb table on the correct DUT.
  2. check the fdb table first to ensure the fdb table is correctly populated before checking snmp, also increase the timeout.

How did you verify/test it?

collected 1 item

snmp/test_snmp_fdb.py::test_snmp_fdb_send_tagged PASSED                                                                                                                                                                                                                [100%]

================================================================================================================== 1 passed, 1 warning in 377.48s (0:06:17) ==================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS
StormLiangMS previously approved these changes Jan 9, 2025
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit dd4023a into sonic-net:master Jan 14, 2025
19 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 14, 2025
* Stabilize `test_snmp_fdb_send_tagged

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16502

@lolyu lolyu deleted the stabilize_test_snmp_fdb_send_tagged branch January 14, 2025 01:30
mssonicbld pushed a commit that referenced this pull request Jan 16, 2025
* Stabilize `test_snmp_fdb_send_tagged

Signed-off-by: Longxiang Lyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants