-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sanity_check][bgp] Enhance sanity check recover for bgp default route missing #16357
Merged
StormLiangMS
merged 3 commits into
sonic-net:master
from
yaqiangz:azure-master_bgp_sanity
Jan 8, 2025
Merged
[sanity_check][bgp] Enhance sanity check recover for bgp default route missing #16357
StormLiangMS
merged 3 commits into
sonic-net:master
from
yaqiangz:azure-master_bgp_sanity
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
azure-master_bgp_sanity
branch
from
January 6, 2025 12:45
de33174
to
211097f
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @StormLiangMS could you please help to review this PR? |
StormLiangMS
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for fix this flaky issue.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 8, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
Cherry-pick PR to 202411: #16386 |
8 tasks
yaqiangz
added
Request for 202405 branch
and removed
Request for 202311 branch
Request for 202405 branch
labels
Jan 8, 2025
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jan 9, 2025
…e missing (sonic-net#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
mssonicbld
pushed a commit
that referenced
this pull request
Jan 13, 2025
…e missing (#16357) What is the motivation for this PR? Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check. How did you do it? Restart exabgp before re-announce routes Add try catch to handle failed to re-announce issue How did you verify/test it? Run test with sanity check
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Jan 13, 2025
Javier-Tan
added
Included in msft-202405 Branch
and removed
Request for msft-202405 Branch
labels
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Sometimes exabgp in ptf would be in incorrect status by stress testing, hence add restarting exabgp before re-announce routes in sanity check.
How did you do it?
How did you verify/test it?
Run test with sanity check
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation